[PATCH] smbget : enable update and various cleanup

[Andrew Bartlett]

On Mon, 2008-02-25 at 21:54 +0100, Jelmer Vernooij wrote:
> Hi Charles,
> 
> Am Montag, den 25.02.2008, 20:58 +0100 schrieb neologix at free.fr:

> > The other one is more interesting: it introduces an "update" mode, where we
> > download a file only if it is newer than its local copy or if there is no local
> > copy. The reason I hacked this is because I use smbget to do a backup of all my
> > samba shares, and it's much better if you download only the new files (resume
> > option doesn't check modification dates, and refuses to overwrite an already
> > existing file). The second thing is really a detail: when using guest mode, it
> > now uses "guest" rather than empty username. The reason for that is that empty
> > wouldn't work for my vista machine, but "guest" does. And it still works for my
> > xp machine, so it shouldn't be a regression. Also, it's a little bit faster than
> > before, because for a download without the resume option, we don't have to go
> > through the whole block.
> This change looks fine mostly and I think it's almost ready to go in.
> Any chance you can send a version of this patch that doesn't depend on
> the first one?
> 
> I'd rather not put the "guest" bit in though, as we define to "" in all
> other Samba client utilities and I think we should be consistent.

Indeed, individual utilities must be as consistent with one another as
possible. 

Andrew Bartlett

-- 
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Red Hat Inc.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20080226/5ae8f71c/attachment.bin