[PATCH] smbget : enable update and various cleanup

Volker Lendecke Volker.Lendecke at SerNet.DE
Mon Feb 25 07:37:42 GMT 2008

On Sun, Feb 24, 2008 at 08:50:17PM +0100, neologix at free.fr wrote:
> Here's a patch that adds an --update option to smbget, so that it will only
> download files if the source is newer than the local copy, or if the file is
> missing. I've added this because it allows me to do backups of all my samba
> shares very simply, without having to re-download every file.
> Also, in the case of guest login, instead of using a void username, it now uses
> "guest", since void didn't work with vista but "guest" does. I also tried with
> windows < vista, and it seems to work.
> Finally, I made a lot of cleanups: I wrote a separate header, removed some
> unnecessary global variables, etc.
> If this patch is accepted, it would be nice if someone could update the manpage
> for the --update option and the Makefile for the new header.

Would it be possible that you send two patches: One with
just the cleanup and the other one with just the functional
change? That would make review a lot easier.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20080225/c3db39cb/attachment.bin

More information about the samba-technical mailing list