[PATCH] creds cache and nt create api in libsmbclient

[Derrell Lipman]

On Feb 18, 2008 7:42 AM, Rafal Szczesniak <mimir at samba.org> wrote:
> On Thu, Feb 14, 2008 at 10:25:35PM -0500, Derrell Lipman wrote:
> > On Thu, Feb 14, 2008 at 8:05 PM, Rafal Szczesniak <mimir at samba.org> wrote:
> >
> > Hi.  I'm not sure what you're trying to accomplish.  libsmbclient
> > provides a POSIX emulation interface, so smbc_nt_create() makes no
> > sense in this context.
>
> It does if you want to open the named pipe. That was the initial motivation
> for these changes.

Hi.  I can certain see that to open a named pipe, one wouldn't be able
to use the existing functions.  However, as a POSIX emulation library,
it still doesn't fit.  You're trying to extend libsmbclient into a
brand new area.  I believe there's merit in this concept but I want to
think about it a bit to ensure that additional non-posix features are
easily handled as well.  I have some ideas, but need to develop them.

In your patch, the addition of cli_full_connection_ccname() is a
complete copy of cli_full_connection().  For maintainability (having
to fix only a single location if bugs are found), I'd suggest instead
to have cli_full_connection() now be a wrapper which simply calls
cli_full_connection_ccname() with a null ccname parameter.  Then in
cli_full_connection_ccname() only call cli_set_ccname() if ccname is
non-null.

I'll be unable to work on how the non-posix functions should fit prior
to next week.  If you haven't heard back from me by the end of the
month, please ping me.

Cheers,

Derrell