[PATCH] Fix off-by-one bugs in subcommand argument passing.
Tim Potter
tpot at hp.com
Sun Feb 17 23:24:51 GMT 2008
---
source/rpcclient/cmd_samr.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/source/rpcclient/cmd_samr.c b/source/rpcclient/cmd_samr.c
index f8b8ba8..8b4ee47 100644
--- a/source/rpcclient/cmd_samr.c
+++ b/source/rpcclient/cmd_samr.c
@@ -1044,8 +1044,8 @@ static NTSTATUS cmd_samr_enum_domains(struct rpc_pipe_client *cli,
return NT_STATUS_OK;
}
- if (argc > 2) {
- sscanf(argv[2], "%x", &access_mask);
+ if (argc > 1) {
+ sscanf(argv[1], "%x", &access_mask);
}
/* Get sam policy handle */
@@ -1194,11 +1194,11 @@ static NTSTATUS cmd_samr_query_aliasinfo(struct rpc_pipe_client *cli,
sscanf(argv[2], "%i", &alias_rid);
- if (argc > 3) {
+ if (argc > 2) {
level = atoi(argv[3]);
}
- if (argc > 4) {
+ if (argc > 3) {
sscanf(argv[4], "%x", &access_mask);
}
--
1.5.2.5
More information about the samba-technical
mailing list