[Patch] Add an idmap implementation to winbind

Stefan (metze) Metzmacher metze at samba.org
Thu Feb 14 13:43:45 GMT 2008

Kai Blin schrieb:
> Hi folks,
> the attached patches allow S4 winbind to do sid<->uid/gid mappings, storing 
> the mappings in a database. I have also switched internal callers of the old 
> dsdb/common/sidmap.c code over to the winbind/idmap.c code.
> This allows us to get rid of the unixName: attributes in the samdb.
> In the long run, the callers should be converted to using the winbind SID2UID 
> etc calls. We will also want to supply a way to import and export mappings in 
> a way compatible to S3, maybe via net idmap dump/restore as well.
> These patches add one of the pieces missing from a full featured member mode 
> for Samba4.
> Comments?

Hi Kai,

thanks for all your work on this!
But please don't push that as is, the code is strange formated
in a lot of places.

else {


if (((ret=bla()) == NULL)

or some other things...

And you should also use transactions.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 249 bytes
Desc: OpenPGP digital signature
Url : http://lists.samba.org/archive/samba-technical/attachments/20080214/4c071e1b/signature.bin

More information about the samba-technical mailing list