[SCM] Samba Shared Repository - branch v3-2-test updated -
jra at samba.org
Thu Feb 7 17:32:04 GMT 2008
On Thu, Feb 07, 2008 at 01:33:41PM +0300, Alexander Bokovoy wrote:
> you're right here, thanks! The difference doesn't change anything in our
> case as dosmode will be calculated once anyway before we get it as an
> argument to file_set_dosmode() so &= compound assignment will not differ
> for that from its corresponding expanded form but it is better to be
> explicit here.
Yep, I know it doesn't change anything, but I added it when
I had to go look up the operator precedence to make sure it
was ok :-). At that point I thought brackets would help :-).
> could you please commit this patch to v3-0-ctdb? (attached)
Is v3-0-ctdb under git ? I don't have bzr installed here
(or know how to use it :-).
More information about the samba-technical