Samba 3.0.32 - internal change notify "legacy" mechanism

Dina Fine dina at
Mon Dec 29 16:02:19 GMT 2008


Well, I applied all (almost :)) your comments.
We use Clear Case so I couldn't easily create a git patch, sorry for


-----Original Message-----
From: Volker Lendecke [mailto:Volker.Lendecke at SerNet.DE] 
Sent: Monday, December 29, 2008 4:53 PM
To: Dina Fine
Cc: Shlomi Yaakobovich; Itay Dar; samba-technical at
Subject: Re: Samba 3.0.32 - internal change notify "legacy" mechanism

On Mon, Dec 29, 2008 at 04:22:38PM +0200, Dina Fine wrote:
> Attached is a new vfs change notify module. The module handles only 
> the


Some comments:

You don't need to patch the file "configure", this is auto-generated
from "" by ./

Same applies to

vfs_notify_hash.c does not carry a valid personal copyright.

Why is timed_event_handler not static?

The indentation in that file is a bit erratic, can you reformat that so
that it compiles with the stuff in README.Coding? Not 100% required, but
it would be great.

Can you make the timeout parameter a module-specific one?
For examples, look for example at the recycle module and its use of

Can you split adding the module as such and the changes to smbd/ into
two patches? You might also want to use "git format-patch" to send the
patches. This way you would get proper credit in "git blame". Bonus if
you send patches that apply cleanly to 3.2, 3.3 and master :-)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: vfs_hash_notify_patch
Type: application/octet-stream
Size: 9621 bytes
Desc: vfs_hash_notify_patch
Url :
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix_patch
Type: application/octet-stream
Size: 3616 bytes
Desc: fix_patch
Url :

More information about the samba-technical mailing list