Samba 3.0.32 - internal change notify "legacy" mechanism

Volker Lendecke Volker.Lendecke at SerNet.DE
Mon Dec 29 14:52:38 GMT 2008

On Mon, Dec 29, 2008 at 04:22:38PM +0200, Dina Fine wrote:
> Attached is a new vfs change notify module. The module handles only the


Some comments:

You don't need to patch the file "configure", this is
auto-generated from "" by ./

Same applies to

vfs_notify_hash.c does not carry a valid personal copyright.

Why is timed_event_handler not static?

The indentation in that file is a bit erratic, can you
reformat that so that it compiles with the stuff in
README.Coding? Not 100% required, but it would be great.

Can you make the timeout parameter a module-specific one?
For examples, look for example at the recycle module and its
use of lp_parm_int.

Can you split adding the module as such and the changes to
smbd/ into two patches? You might also want to use "git
format-patch" to send the patches. This way you would get
proper credit in "git blame". Bonus if you send patches that
apply cleanly to 3.2, 3.3 and master :-)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url :

More information about the samba-technical mailing list