cli_trans changes in wip.git

Volker Lendecke Volker.Lendecke at SerNet.DE
Fri Dec 19 12:09:35 GMT 2008


Hi, Kai!

After taking a brief look at your wip branch (thanks for
going through all the calls :-)) there is one comment I
would like to make: The clistr_push function references
cli->outbuf as a base for UCS2 alignment of the string to
push. With the new calls, cli->outbuf is not used anymore
and will be completely removed at some point. Same is true
for cli->inbuf. So, we should find another way to do proper
alignment of the strings pushed without accessing
cli->outbuf.

Thanks,

Volker
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20081219/19795d9c/attachment.bin


More information about the samba-technical mailing list