[SCM] Samba Shared Repository - branch master updated - 1a399db01c90753f0f1c70b2987b925c828b1c53

simo simo at samba.org
Thu Dec 18 20:49:09 GMT 2008


On Fri, 2008-12-19 at 07:41 +1100, Andrew Bartlett wrote:
> On Thu, 2008-12-18 at 13:17 -0500, simo wrote:
> > On Wed, 2008-12-17 at 21:37 -0600, Andrew Bartlett wrote:
> > > @@ -1009,7 +1009,7 @@ static int ltdb_index_filter(const struct 
> > > dn_list *dn_list,
> > > -               ret = ltdb_search_dn1_wrap(ac->module, dn, msg);
> > > +               ret = ltdb_search_dn1(ac->module, dn, msg);
> > 
> > Andrew are you sure this is correct ?
> > It is inconsistent with other changes in this patch set.
> 
> It is.  I carefully checked, which is why I added the assert to the
> other cases.  (This is actually looking up the target, not index
> records, and I wanted to be more clear about the split). 

Maybe a comment to that effect would have been helpful, but as long as
it is correct I am fine :)

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Senior Software Engineer at Red Hat Inc. <simo at redhat.com>



More information about the samba-technical mailing list