Extending LDB for Extended DNs

[simo]

On Mon, 2008-12-15 at 19:39 +0100, Stefan (metze) Metzmacher wrote:
> Andrew Bartlett schrieb:
> > On Fri, 2008-12-12 at 12:35 +0100, Stefan (metze) Metzmacher wrote:
> >> Andrew Bartlett schrieb:
> >>> On Wed, 2008-12-03 at 13:38 +1100, Andrew Bartlett wrote:
> >>>> On Tue, 2008-12-02 at 21:21 -0500, simo wrote:
> >>>>> On Wed, 2008-12-03 at 11:35 +1100, Andrew Bartlett wrote:
> >>>>>> On Fri, 2008-11-21 at 18:28 +1100, Andrew Bartlett wrote:
> >>>>>>> On Fri, 2008-11-14 at 18:23 +1100, Andrew Bartlett wrote:
> >>>>>>>> On Wed, 2008-11-05 at 22:33 +1100, Andrew Bartlett wrote:
> >>>>>>>>> Great.  I've been working on this hard for the past week or so.  See
> >>>>>>>>> http://gitweb.samba.org/?p=abartlet/samba.git/.git;a=shortlog for the
> >>>>>>>>> current work in progress.
> >>> I've just updated this tree again.
> >>>
> >>>>> Anyway I would not put it in if it is going to break the LDAP backend,
> >>>>> we should have it working for.
> >>>>> I have gone through great pain myself to make sure my stuff did work
> >>>>> with LDAP with the async patches, is there a reason to apply a different
> >>>>> standard in this case ?
> >>>> No, there isn't, and you are right to hold me to that standard.  I'm
> >>>> working on the changes to allow this to work with OpenLDAP's dereference
> >>>> control right now.  
> >>> I've updated my tree, and with some small changes to ldb
> >>> (ldb_module_send_entry() now takes a control parameter) and a lot of
> >>> other work on modules and control parsing, it all works!
> >>>
> >>> I would like to merge the above tree into 'master'. 
> >>>
> >>> Any comments?
> >> I'll review your stuff over the weekend.
> > 
> > I'll brace myself :-)
> > 
> > But seriously, while I know it will mean more work for me, I do
> > appreciate your reviews.
> 
> I didn't looked at as close as I wished, as it's not that easy to
> review with all the merges and bug fix commits.
> 
> But I think you should push it to master.

It would be nice to see a clear diff before the push at least.
I personally would also like a rebase much more, but our samba git is
cluttered enough already that probably it won't make much difference in
the noise :-(

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Senior Software Engineer at Red Hat Inc. <simo at redhat.com>