[SCM] Samba Shared Repository - branch v3-3-test updated - release-3-2-0pre2-4678-gfc4366c

[Jeremy Allison]

On Fri, Dec 12, 2008 at 10:54:29AM -0600, Karolin Seeger wrote:
> The branch, v3-3-test has been updated
>        via  fc4366ca11cac97819eb06a744cf8e35b4524bcc (commit)
>       from  6459f00d1cad1d5e9e14851610ca7a92406ad54a (commit)
> 
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-3-test
> 
> 
> - Log -----------------------------------------------------------------
> commit fc4366ca11cac97819eb06a744cf8e35b4524bcc
> Author: Volker Lendecke <vl at sernet.de>
> Date:   Fri Dec 12 13:47:41 2008 +0100
> 
>     Fix error code when smbclient puts a file over an existing directory
>     
>     Windows returns NT_STATUS_FILE_IS_A_DIRECTORY, as does Samba 3.0. 3.2 and
>     following returned NT_STATUS_INVALID_PARAMETER which is wrong.
>     
>     Before I converted reply_open_and_X to create_file() we called
>     open_file_ntcreate directly. Passing through open&X for a filename that exists
>     as a directory ends up in open_directory after having tried open_file_ntcreate.
>     Some check in there returns NT_STATUS_INVALID_PARAMETER. With this additional
>     FILE_NON_DIRECTORY_FILE flag we get the correct error message back from
>     create_file_unixpath before trying open_directory().
>     
>     Survives make test, but as this also touches the other open variants I would
>     like others to review this.

Wow, that's a very elegant and simple fix ! Thanks Volker, I'm
writing a torture test for this now.

Jeremy.