[SCM] Samba Shared Repository - branch master updated - 6e4cc12604f6bcf53961326d497f118dfe5da139

[Matthias Dieter Wallnöfer]

Ah, interesting.
I've changed the behaviour in the SAMR code in the sense that the user 
parameters shouldn't be set on null strings (to avoid the LDB empty 
string problem). But I didn't perform a OpenLDAP backend test. The 
torture test without backend performed well.

Matthias

Andrew Bartlett schrieb:
> On Tue, 2008-12-09 at 17:08 -0600, Günther Deschner wrote:
>   
>> The branch, master has been updated
>>        via  6e4cc12604f6bcf53961326d497f118dfe5da139 (commit)
>>        via  91bfd5f201f302156fac7f1bc7a685e6f3c22cf3 (commit)
>>       from  e0711ffa526e22e3ffe483319ce5d7725d578647 (commit)
>>
>> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>>
>>
>> - Log -----------------------------------------------------------------
>> commit 6e4cc12604f6bcf53961326d497f118dfe5da139
>> Author: Matthias Dieter Wallnöfer <mwallnoefer at yahoo.de>
>> Date:   Tue Dec 9 23:32:04 2008 +0100
>>
>>     s4-samr: Fix Bug #5946. userparameters handling in torture test.
>>     
>>     Signed-off-by: Günther Deschner <gd at samba.org>
>>
>> commit 91bfd5f201f302156fac7f1bc7a685e6f3c22cf3
>> Author: Matthias Dieter Wallnöfer <mwallnoefer at yahoo.de>
>> Date:   Tue Dec 9 23:31:15 2008 +0100
>>
>>     s4-samr: Fix Bug #5946. userparameters handling in samr server.
>>     
>>     Signed-off-by: Günther Deschner <gd at samba.org>
>>     
>
> The OpenLDAP backend does not like zero-length strings, and I'm
> presuming it's your new tests. 
>
> I'm wondering if you have any ideas how we can correctly store these ""
> userParameters.  Should we instead not store the parameter?
>
> = Failed tests =
> == samba4.rpc.samr.users on ncacn_np with connect (dc) ==
> ENVLOG: SMBD LOG of: localdc1
> Failed to modify record
> CN=samrtorturetest,CN=Users,dc=samba,dc=example,dc=com: LDAP error 21
> LDAP_INVALID_ATTRIBUTE_SYNTAX -  <userParameters: value #0 invalid per
> syntax> <>
> Failed to modify record
> CN=samrtorturetest,CN=Users,dc=samba,dc=example,dc=com: LDAP error 21
> LDAP_INVALID_ATTRIBUTE_SYNTAX -  <userParameters: value #0 invalid per
> syntax> <>
> Failed to modify record
> CN=samrtorturetest,CN=Users,dc=samba,dc=example,dc=com: LDAP error 21
> LDAP_INVALID_ATTRIBUTE_SYNTAX -  <userParameters: value #0 invalid per
> syntax> <>
> Failed to modify record
> CN=samrtorturetest,CN=Users,dc=samba,dc=example,dc=com: error in module
> entryuuid: Operations error (1)
> Failed to modify record
> CN=samrtorturetest,CN=Users,dc=samba,dc=example,dc=com: error in module
> entryuuid: Operations error (1)
> Failed to modify record
> CN=samrtorturetest,CN=Users,dc=samba,dc=example,dc=com: error in module
> entryuuid: Operations error (1)
>
>