[PATCH] Add --with-ext-lib-XXX support to SMB_EXT_LIB_FROM_PKGCONFIG

Sam Liddicott sam at liddicott.com
Wed Dec 10 10:21:18 GMT 2008


* Jelmer Vernooij wrote, On 26/11/08 20:46:
> On Wed, 2008-11-26 at 20:02 +0000, Sam Liddicott wrote:
>   
>> Jelmer Vernooij wrote: 
>>     
>>> On Wed, Nov 26, 2008 at 06:19:30PM -0000, Sam Liddicott wrote:
>>>   
>>>       
>>>> How about --enable-internal-libldb ?
>>>>     
>>>>         
>>> Yeah, that would make sense as well (perhaps more than
>>> --enable-external, if auto is going to be the default). In the meantime, 
>>> I incorporated my comments in your patch. The result is attached.
>>>   
>>>       
>> I don't mind if you re-write half a days reading and work in only half
>> an hour!
>> Looks good to me...
>>     
> I'm sorry, I didn't intend to redo your work :-( My patch was still
> based on yours though. 
>   
np
> I'll push this into master.
>   
Have you pushed yet?

Sam


More information about the samba-technical mailing list