[SCM] Samba Shared Repository - branch v3-2-test updated - release-3-2-0pre2-3236-g66c0885

Jeremy Allison jra at samba.org
Sat Dec 6 05:07:18 GMT 2008


On Fri, Dec 05, 2008 at 08:07:04PM -0600, Tim Prouty wrote:
> The branch, v3-2-test has been updated
>        via  66c08857fbf78a24e7770e1d1bf8938bb938b271 (commit)
>       from  635373512634a05d65b009e4ec3669a227b2b94d (commit)
> 
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test
> 
> 
> - Log -----------------------------------------------------------------
> commit 66c08857fbf78a24e7770e1d1bf8938bb938b271
> Author: Dan Sledz <dsledz at isilon.com>
> Date:   Fri Dec 5 17:29:38 2008 -0800
> 
>     Fix logging to syslog
> 
> -----------------------------------------------------------------------
> 
> Summary of changes:
>  source/lib/debug.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> 
> Changeset truncated at 500 lines:
> 
> diff --git a/source/lib/debug.c b/source/lib/debug.c
> index d91b55d..b3e1a72 100644
> --- a/source/lib/debug.c
> +++ b/source/lib/debug.c
> @@ -851,7 +851,7 @@ void check_log_size( void )
>  		ret = vasprintf(&msgbuf, format_str, ap);
>  		va_end(ap);
>  
> -		if (ret == -1) {
> +		if (ret != -1) {
>  			syslog(priority, "%s", msgbuf);
>  		}
>  		SAFE_FREE(msgbuf);

Wow, thanks for that fix. I'm embarrassed that this
mistake slipped though for so long.

Jeremy.


More information about the samba-technical mailing list