[SCM] Samba Shared Repository - branch master updated - 2719216d60088eb3f10a2e3e968f15e8089b5491

Jeremy Allison jra at samba.org
Wed Dec 3 00:44:09 GMT 2008


On Fri, Nov 28, 2008 at 02:32:58AM -0600, Volker Lendecke wrote:
> The branch, master has been updated
>        via  2719216d60088eb3f10a2e3e968f15e8089b5491 (commit)
>       from  9a3be6f0f8e120797a02fa1be60b51812cfd86f5 (commit)
> 
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> 
> 
> - Log -----------------------------------------------------------------
> commit 2719216d60088eb3f10a2e3e968f15e8089b5491
> Author: Volker Lendecke <vl at samba.org>
> Date:   Sat Nov 8 17:08:57 2008 +0100
> 
>     Consolidate the buffer checks for the reply_trans style functions
>     
>     This is the one where I found the problem that led to 3.2.5. So if there is one
>     checkin in the last year that I would like others to review and *understand*,
>     it is this one :-)

Ok, I really like this. Very nice cleanup. The only thing :

I think "(offset + length < offset)" and
"(offset + length < length)" is redundent. We only need one
I believe. Doesn't hurt having both though.

Jeremy.


More information about the samba-technical mailing list