; a=shortlog; h=create_file_refactor

Tim Prouty tprouty at
Mon Dec 1 18:27:50 GMT 2008

On Dec 1, 2008, at 9:53 AM, Jeremy Allison wrote:

> Ok, hope I'm not too late on this. Rather than adding a
> bool argument to the CREATE_FILE vfs interface, can we add
> a uint32_t flags field instead and make is_dos_path a flag ?
> The reason I'd like to do this is that I think that the
> current method of overloading INTERNAL_OPEN_ONLY onto
> the oplock_request field is a bad decision, and would
> like to move that to a flags option.
> We may also need another flag here to deal with the
> oplock implications of opening a stream handle with
> kernel oplocks.
> Vl, Tim, what do you think ?

That sounds fine to me.  I'll work on those changes and do some  
testing this afternoon.


More information about the samba-technical mailing list