[SCM] Samba Shared Repository - branch v3-devel updated -
release-3-2-0pre2-3834-g91f85d0
simo
idra at samba.org
Wed Aug 27 00:55:48 GMT 2008
On Tue, 2008-08-26 at 18:15 -0500, Jeremy Allison wrote:
> The branch, v3-devel has been updated
> via 91f85d0dcaa917b7a90a77852f3a778a0ad99c4d (commit)
> from 566d3b6e76afeca8e862cb36202a5283b86920e4 (commit)
>
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-devel
>
>
> - Log -----------------------------------------------------------------
> commit 91f85d0dcaa917b7a90a77852f3a778a0ad99c4d
> Author: Jeremy Allison <jra at samba.org>
> Date: Tue Aug 26 16:14:25 2008 -0700
>
> Don't ask winbindd if we got a -ve cache entry.
> Jeremy.
>
> -----------------------------------------------------------------------
>
> Summary of changes:
> source/passdb/lookup_sid.c | 42 ++++++++++++++++++++++++++++++++++++++----
> 1 files changed, 38 insertions(+), 4 deletions(-)
>
>
> Changeset truncated at 500 lines:
>
> diff --git a/source/passdb/lookup_sid.c b/source/passdb/lookup_sid.c
> index 4b2edd5..a5e3362 100644
> --- a/source/passdb/lookup_sid.c
> +++ b/source/passdb/lookup_sid.c
> @@ -1296,7 +1296,16 @@ void uid_to_sid(DOM_SID *psid, uid_t uid)
> /* Check the winbindd cache directly. */
> ret = idmap_cache_find_uid2sid(uid, psid, &expired);
>
> - if (!ret || expired || (ret && is_null_sid(psid))) {
> + if (ret && is_null_sid(psid)) {
Jeremy,
I think this one should be instead:
if (!expired && ret && is_null_sid(psid)) {
Otherwise you do not try when the negative cache is expired.
Analogous for the other cases.
Simo.
--
Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Senior Software Engineer at Red Hat Inc. <simo at redhat.com>
More information about the samba-technical
mailing list