[linux-cifs-client] [PATCH 2/2] cifs.upcall: enable building by default on linux

[simo]

On Sun, 2008-08-17 at 12:37 -0400, Jeff Layton wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On Sun, 17 Aug 2008 10:19:38 -0400
> simo <idra at samba.org> wrote:
> 
> > On Sat, 2008-08-16 at 22:29 -0400, jlayton at samba.org wrote:
> > > -[AS_HELP_STRING([--with-cifsupcall], [Include cifs.upcall (Linux
> > > only) support (default=no)])],
> > > +[AS_HELP_STRING([--with-cifsupcall], [Include cifs.upcall (Linux
> > > only) support (default=yes)])],
> > 
> > this should be probably marked as "default=auto" meaning that configure
> > will determine whether it is appropriate or not for the platform it is
> > being built on. It is how we mark any other option like this.
> > 
> > Simo.
> > 
> 
> We're using more or less the same logic here as mount.cifs and for
> that, the default is listed as "yes". They already say "Linux only", so
> it seems to me like "yes" is a reasonable way to list the default.
> 
> If you think this needs to be changed though, then we should also
> change it for mount.cifs.

I'll defer to others to comment on the necessity, if nobody replies or
express a preference let it in as is and feel free to push.

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Senior Software Engineer at Red Hat Inc. <simo at redhat.com>