[PATCH] Attempt to fix Coverity ID 596

Volker Lendecke vl at sernet.de
Sat Aug 16 09:12:35 GMT 2008


Jeremy, please check & push if it's ok.
---
 source/winbindd/winbindd_passdb.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/source/winbindd/winbindd_passdb.c b/source/winbindd/winbindd_passdb.c
index e4cf029..8387565 100644
--- a/source/winbindd/winbindd_passdb.c
+++ b/source/winbindd/winbindd_passdb.c
@@ -217,7 +217,7 @@ static NTSTATUS rids_to_names(struct winbindd_domain *domain,
 			(*names)[i] = CONST_DISCARD(char *, nam);
 		}
 
-		if (domain_name == NULL) {
+		if (*domain_name == NULL) {
 			*domain_name = CONST_DISCARD(char *, dom);
 		} else {
 			char *dname = CONST_DISCARD(char *, dom);
-- 
1.5.5



More information about the samba-technical mailing list