[PATCH] cifs.upcall: negatively instantiate keys on error

Jeff Layton jlayton at redhat.com
Tue Aug 5 19:49:17 GMT 2008

When a request-key upcall exits without instantiating a key, the kernel
will negatively instantiate the key with a 60s timeout. Older kernels,
however seem to also link that key into the session keyring. This
behavior can interefere with subsequent mount attempts until the
key times out. The next request_key() call will get this negative key
even if the upcall would have worked the second time.

Fix this by having cifs.upcall negatively instantiate the key itself
with a 1s timeout and don't attach it to the session keyring.

Signed-off-by: Jeff Layton <jlayton at redhat.com>
 source/client/cifs.upcall.c |   12 ++++++++++--
 1 files changed, 10 insertions(+), 2 deletions(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ac9beeaf37ab8cd6a4a440e5f87ec47a5c57a085.diff
Type: text/x-patch
Size: 1249 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20080805/1701283a/ac9beeaf37ab8cd6a4a440e5f87ec47a5c57a085.bin

More information about the samba-technical mailing list