[SCM] Samba Shared Repository - branch v3-0-test updated - release-3-0-31-9-gd29db97]

[Karolin Seeger]

Hi Jerry, list,

There is a bug in Samba 3.0.31's net command.

To show the behaviour without patch:

-----8<------------------snip--------------8<--------------
bando:~ # net rpc trustdom list
Connection failed: NT_STATUS_UNSUCCESSFUL
[2008/08/05 11:39:09.050683, 0, pid=21275]
utils/net_rpc.c:rpc_trustdom_list(6081)
  Couldn't connect to domain controller
----->8------------------snap-------------->8--------------

-----8<------------------snip--------------8<--------------
bando:~ # net rpc trustdom list -U root
Connection failed: NT_STATUS_UNSUCCESSFUL
[2008/08/05 11:39:12.889172, 0, pid=21276]
utils/net_rpc.c:rpc_trustdom_list(6081)
  Couldn't connect to domain controller
----->8------------------snap-------------->8--------------

-----8<------------------snip--------------8<--------------
bando:~ # net rpc trustdom list -U root%pw
Trusted domains list:

none

Trusting domains list:

none
----->8------------------snap-------------->8--------------

So the interactive password prompting does not work.
The patch fixes the issue.

Is that worth a new 3.0 release?


Karolin

----- Forwarded message from Karolin Seeger <kseeger at samba.org> -----

To: samba-cvs at samba.org
Date: Mon,  4 Aug 2008 07:34:26 -0500 (CDT)
From: Karolin Seeger <kseeger at samba.org>
Subject: [SCM] Samba Shared Repository - branch v3-0-test updated -
	release-3-0-31-9-gd29db97

The branch, v3-0-test has been updated
       via  d29db976dcffef772044b1e5246ec6715d6afbbb (commit)
      from  062bd2592e249cce426369b92c2238a4deb33956 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-0-test


- Log -----------------------------------------------------------------
commit d29db976dcffef772044b1e5246ec6715d6afbbb
Author: Michael Adam <obnox at samba.org>
Date:   Mon Aug 4 13:31:26 2008 +0200

    net: Fix IPC connections with interactive password prompt.
    
    This fixes a regression introduced with 52f916c6.
    Some net subcommands didn't work when the username, but not the
    corresponding password was given on the command line.

-----------------------------------------------------------------------

Summary of changes:
 source/utils/net.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/utils/net.c b/source/utils/net.c
index d8ea462..38ebaf6 100644
--- a/source/utils/net.c
+++ b/source/utils/net.c
@@ -496,7 +496,7 @@ struct cli_state *net_make_ipc_connection_ex( const char *domain, const char *se
 		server_ip = *ip;
 	}
 
-	if (opt_user_name && opt_password) {
+	if (opt_user_name) {
 		nt_status = connect_to_ipc(&cli, &server_ip, server_name);
 		if (NT_STATUS_IS_OK(nt_status)) {
 			goto connected;


-- 
Samba Shared Repository


----- End forwarded message -----

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.SerNet.DE, mailto: Info @ SerNet.DE

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 194 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20080805/332ebfa5/attachment.bin