Improving performance of winbindd_list_groups
Gerald (Jerry) Carter
jerry at samba.org
Tue Apr 29 19:45:49 GMT 2008
-----BEGIN PGP SIGNED MESSAGE-----
Jeremy Allison wrote:
| On Thu, Apr 24, 2008 at 05:51:13PM -0700, Steven Danneman wrote:
|>> Looks very good to me, thanks!
|>> Just a quick comment: In listgroups_recv you're using talloc_asprintf
|> to paste the
|>> results together. These strings can get *very* long, so you might want
|> to use
|>> talloc_asprintf_append_buffer, which does not use strlen for the
|> existing string.
|>> Jerry, what do you think about this patch?
|> Thanks Volker,
|> That's a good suggestion for even better performance. Attached is an
|> updated patch using talloc_asprintf_append_buffer(). I'm wasn't
|> positive from the API description that the returned string will be NULL
|> terminated, but in all my tests it seems to be. Is this a correct
| Jerry, just waiting on your go ahead to push this one...
I know. Thanks for waiting.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v220.127.116.11 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
More information about the samba-technical