Improving performance of winbindd_list_groups

Volker Lendecke Volker.Lendecke at SerNet.DE
Fri Apr 25 11:08:20 GMT 2008


On Thu, Apr 24, 2008 at 05:51:13PM -0700, Steven Danneman wrote:
> That's a good suggestion for even better performance.  Attached is an
> updated patch using talloc_asprintf_append_buffer().  I'm wasn't
> positive from the API description that the returned string will be NULL
> terminated, but in all my tests it seems to be.  Is this a correct
> assumption?

Yep. Down below it calls vsnprintf somewhere, that
terminates. I'd check in your patch, but I'd like Jerry to
take a look and comment first.

Volker
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20080425/1d8e9d05/attachment.bin


More information about the samba-technical mailing list