[SCM] Samba Shared Repository - branch v3-2-test updated - release-3-2-0pre2-2199-gcc23f91

Andreas Schneider anschneider at suse.de
Fri Apr 25 08:02:23 GMT 2008


Jeremy Allison wrote:

Hi Jeremy,

> @@ -67,6 +68,13 @@
>  
>  #define CONST_DISCARD(type, ptr)      ((type) ((void *) (ptr)))
>  
> +#ifndef SAFE_FREE
> +#define SAFE_FREE(x) do { if ((x) != NULL) {free(x); x=NULL;} } while(0)
> +#endif
> +
> +#define MOUNT_PASSWD_SIZE 64
> +#define DOMAIN_SIZE 64
> +
>  const char *thisprogram;
>  int verboseflag = 0;
>  static int got_password = 0;

Windows versions above Windows 98 (Windows 2000, XP and above including 
Samba), support passwords up to 127 characters.

There is a patch on the linux-cifs mailinglist to extend the password check.

http://lists.samba.org/archive/linux-cifs-client/2008-January/002606.html

So shouldn't MOUNT_PASSWD_SIZE set to 128 and the patch from the mailinglist 
applied too?


Cheers,

	-- andreas

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 257 bytes
Desc: OpenPGP digital signature
Url : http://lists.samba.org/archive/samba-technical/attachments/20080425/36a463ca/signature.bin


More information about the samba-technical mailing list