Improving performance of winbindd_list_groups
steven.danneman at isilon.com
Fri Apr 25 00:51:13 GMT 2008
> Looks very good to me, thanks!
> Just a quick comment: In listgroups_recv you're using talloc_asprintf
to paste the
> results together. These strings can get *very* long, so you might want
> talloc_asprintf_append_buffer, which does not use strlen for the
> Jerry, what do you think about this patch?
That's a good suggestion for even better performance. Attached is an
updated patch using talloc_asprintf_append_buffer(). I'm wasn't
positive from the API description that the returned string will be NULL
terminated, but in all my tests it seems to be. Is this a correct
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 12837 bytes
Url : http://lists.samba.org/archive/samba-technical/attachments/20080424/c5ceae85/Make-WINBINDD_LIST_GROUPS-handler-asynchronous.obj
More information about the samba-technical