Proposal to remove wbinfo --sequence

simo idra at samba.org
Wed Apr 23 11:33:10 GMT 2008


On Tue, 2008-04-22 at 17:03 -0500, Gerald (Jerry) Carter wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Folks,
> 
> Metze and I discussed the sequence number stuff in Winbind
> and both agree that the wbinfo --sequence call is fairly useless.
> 
> Attached are a pair of patches that xtend the struct wbcDOmainInfo
> in the libwbclient API to include the OFFLINE status of domains.
> This also includes a "wbinfo --online-status" command
> and deprecates the "wbinfo --sequence" operation.
> 
> The only thing failing is that the main parent Winbind daemon
> does not know the status of all domains.  I could follow the
> path that wmbcontrol did and use messages.  I'm wondering if
> we should store a online/offline record for each domain rather
> than requiring each child process to figure it out.  But this
> is more work and too much for right now.
> 
> If ppl agree then I will find some existing way to actually
> report the online/offline status in the next patch.
> 
> Please review.  Thanks.


Looks good, if possible it would be nice to have winbind children share
status and keep it updated when an event happens.
To me it seem more efficient and simple to maintain than using messaging
to force an update of the status.

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Senior Software Engineer at Red Hat Inc. <ssorce at redhat.com>



More information about the samba-technical mailing list