Nicer commits (please:-)

[Stefan (metze) Metzmacher]

Hi,

while cherry picking commits for v3-2-stable I found
a few commits which can't be picked.

3fc85d22590550f0539215d020e4411bf5b14363 Coverity fixes
 source/client/client.c                 |    5 ++++-
 source/include/rpc_client.h            |   12 ++++--------
 source/lib/sock_exec.c                 |    2 +-
 source/libads/kerberos.c               |    6 ++++--
 source/libads/krb5_setpw.c             |   17 ++++++++++++++---
 source/libads/ldap.c                   |    5 ++++-
 source/nsswitch/wins.c                 |   10 ++++++++--
 source/passdb/pdb_ldap.c               |   14 ++++++++++----
 source/passdb/pdb_smbpasswd.c          |    6 ++++--
 source/printing/nt_printing.c          |   29 ++++++++++++++++++++---------
 source/registry/reg_backend_printing.c |    3 ++-
 source/registry/regfio.c               |    5 ++++-
 source/rpc_client/cli_pipe.c           |   23 +++++++++++++----------
 source/rpc_client/ndr.c                |    5 +----
 source/rpc_parse/parse_buffer.c        |    6 ++++--
 source/rpc_parse/parse_misc.c          |   27 ++++++++++++++++++---------
 source/rpc_parse/parse_prs.c           |    2 +-
 source/rpc_server/srv_pipe.c           |   16 ++++++++--------
 source/rpc_server/srv_pipe_hnd.c       |    6 +++---
 source/rpc_server/srv_spoolss_nt.c     |    6 +++++-
 source/rpc_server/srv_winreg_nt.c      |    6 ++++--
 source/services/services_db.c          |    7 ++++++-
 source/smbd/notify.c                   |    2 +-
 source/smbd/uid.c                      |    7 ++++++-
 source/utils/net_rpc.c                 |    7 +++++--
 source/utils/rpccheck.c                |    3 ++-
 source/utils/smbget.c                  |    7 ++++++-
 27 files changed, 162 insertions(+), 82 deletions(-)

This should have been about 27 single commits.

cbdb79b7a1044945e515a294f487e4c1a9c91be5 fix some extrasemi compile warnings
 source/libgpo/gpo_reg.c                |    2 +-
 source/nsswitch/libwbclient/wbclient.c |    2 +-
 source/param/loadparm.c                |    4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

This should have been 3 single commits.

Also the commit messages should be better and the first
should give a hint what the commit is actually for.

It should be possible to read the output of:
git log --pretty=oneline
and
git cherry origin/v3-2-stable origin/v3-2-test |grep '^+'

So instead of
40d1d64c6a2ae128eb3fce0e7f5351b0c5942f30 Fix a segfault
please use something like
groupdb: Fix segfault in mapping_tdb.c
or
mapping_tdb: Pass 0 as size to tdb_pack() to fix a segfault

More complex messages should have a 'headline' followed
by a empty line and then a the 'body' with a more detailed
description and a reference to a bug number or mail thread.

I think it would be very useful to follow this simple rules
as it makes it much easier to get an overview what has changed
and what needs to be merged between branches.

Comments are welcome:-)

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 249 bytes
Desc: OpenPGP digital signature
Url : http://lists.samba.org/archive/samba-technical/attachments/20080412/28115c33/signature.bin