Samba4 Provisioning Segmentation Fault version.c

[Andrew Bartlett]

On Thu, 2008-04-03 at 17:15 +0100, David Holder wrote:
> Hi! I have been getting SEGV when trying to provision samba4 test and 
> samba4 stable.
> 
> I finally worked out that the use of two version.h header files seems to 
> be the cause. One in source and the other in source/include. Both 
> contain #defines for SAMBA_VERSION_STRING one defines it as a string the 
> other as the function samba_version_string().
> 
> The function samba_version_string() is defined in version.c using 
> SAMBA_VERSION_STRING. On my system, version.c uses the 
> SAMBA_VERSION_STRING define from include/version as its return value. 
> This is defined as samba_version_string(). I.e. it defines it's return 
> value by calling itself.
> 
> I fixed the problem using the following:
> 
> diff --git a/source/lib/version.c b/source/lib/version.c
> index e81f463..7a250d8 100644
> --- a/source/lib/version.c
> +++ b/source/lib/version.c
> @@ -19,7 +19,7 @@
>  */
> 
>  #include "includes.h"
> -#include "version.h"
> +#include "../version.h"
> 
>  const char *samba_version_string(void)
>  {
> 
> I assume no one else has this problem. Any ideas why I do? 

I think the problem is that version.h moved months ago, but you still
have the old copy in your tree.

Andrew Bartlett

-- 
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Red Hat Inc.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20080404/df4a9a79/attachment.bin