[patch 3 of 3] 3.2 test - categorize profiling

Jeremy Allison jra at samba.org
Wed Apr 2 21:55:47 GMT 2008


On Thu, Apr 03, 2008 at 07:51:36AM +1000, David Disseldorp wrote:
> On Mon, 31 Mar 2008 10:01:09 +1000
> David Disseldorp <ddiss at sgi.com> wrote:
> 
> > do_not_use_printf_star (*Attached*)
> >  - categorize_profiling uses the '*' field width specifier with
> >    printf. Apparently Solaris libc does not support this.
> 
> David Collier-Brown confirmed the "%*s" printf format specifier functions
> correctly on Solaris. The patch 'do_not_use_printf_star' should not be
> pushed unless it is known to cause problems on other platforms.

Thanks - yes, I think that was my mistake. Volker correctly identified
the bug as a problem in our printf-style processing.

Cheers,

Jeremy.


More information about the samba-technical mailing list