svn commit: samba r25272 - in branches: SAMBA_3_2/source/winbindd SAMBA_3_2_0/source/winbindd

Jeremy Allison jra at samba.org
Fri Sep 21 16:35:56 GMT 2007


On Fri, Sep 21, 2007 at 04:40:01PM +0200, Michael Adam wrote:
> On Fri, Sep 21, 2007 at 06:10:36AM -0700, Jeremy Allison wrote:
> > On Fri, Sep 21, 2007 at 01:12:28PM +0200, Michael Adam wrote:
> > > 
> > > Btw: Most callers i saw use "sizeof(target_area) - 1".
> > > But if I did not misread the pull_ucs2 code, it should
> > > be safe to specify sizeof(target_area). Is that right?
> > 
> > Yes, absolutely. I almost went though and fixed all these,
> > they were due to a misunderstanding of the API, but there
> > were too many to fix in the time I had. We should probably
> > tidy these up sometime :-).
> 
> Jeremy, see r25294. I hope none of the callers escaped my
> attention. :-)

Thanks for the tidyup :-). Much appreciated.

Jeremy.


More information about the samba-technical mailing list