svn commit: samba r25272 - in branches: SAMBA_3_2/source/winbindd SAMBA_3_2_0/source/winbindd

[Jeremy Allison]

On Fri, Sep 21, 2007 at 01:12:28PM +0200, Michael Adam wrote:
> On Fri, Sep 21, 2007 at 02:55:21AM -0700, Jeremy Allison wrote:
> > On Fri, Sep 21, 2007 at 09:52:29AM +0000, obnox at samba.org wrote:
> > > Author: obnox
> > > Date: 2007-09-21 09:52:28 +0000 (Fri, 21 Sep 2007)
> > > New Revision: 25272
> > > 
> > > WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=25272
> > > 
> > > Log:
> > > Fix a bunch of callers of pull_ucs2 that passed -1 for dest_len.
> > > 
> > 
> > Michael, your patch and mine crossed on the wire. Your patch
> > is incorrect - we need to be using 'sizeof(target_area)' not
> > sizeof(fstring) - that way can lead to errors if the data
> > size gets changed.
> 
> Jeremy, this is of course much much better. Thanks!
> 
> Btw: Most callers i saw use "sizeof(target_area) - 1".
> But if I did not misread the pull_ucs2 code, it should
> be safe to specify sizeof(target_area). Is that right?

Yes, absolutely. I almost went though and fixed all these,
they were due to a misunderstanding of the API, but there
were too many to fix in the time I had. We should probably
tidy these up sometime :-).

Thanks,

	Jeremy.