svn commit: samba r25272 - in branches: SAMBA_3_2/source/winbindd SAMBA_3_2_0/source/winbindd

Jeremy Allison jra at samba.org
Fri Sep 21 09:55:21 GMT 2007


On Fri, Sep 21, 2007 at 09:52:29AM +0000, obnox at samba.org wrote:
> Author: obnox
> Date: 2007-09-21 09:52:28 +0000 (Fri, 21 Sep 2007)
> New Revision: 25272
> 
> WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=25272
> 
> Log:
> Fix a bunch of callers of pull_ucs2 that passed -1 for dest_len.
> 

Michael, your patch and mine crossed on the wire. Your patch
is incorrect - we need to be using 'sizeof(target_area)' not
sizeof(fstring) - that way can lead to errors if the data
size gets changed.

Jeremy.


More information about the samba-technical mailing list