is it initialized

Jeremy Allison jra at samba.org
Tue Sep 18 05:52:13 GMT 2007


On Tue, Sep 18, 2007 at 12:46:53PM +1000, Andrew Bartlett wrote:
> On Fri, 2007-09-14 at 00:01 +0300, Yakov Lerner wrote:
> > Array md4_buf[] is used uninitialized in line 194 lib/genrand.c
> > for all I can see (function generate_random_buffer()) .
> > 
> > I can see possibility why this can be intentional () (... in order
> > to increase  entropy of the generated output ? ... but this still
> > looks weird .. no explanatory comment ... )
> > 
> > Is this indeed intentional ?
> 
> Yes.  I'm sure I've seen a comment above this on some versions.   It is
> the kind of thing that causes valgrind no end of fun, but fortunately on
> linux, we use /dev/urandom.

Yes, it was intentional when I wrote it. I wanted to increase
the randomness here. It does upset valgrind though :-(.

Jeremy.


More information about the samba-technical mailing list