[PATCH] Samba 4 fix for bugzilla #4958

[simo]

On Sun, 2007-09-16 at 17:11 -0500, Andrew Kroeger wrote:
> The attached patch fix the error when a rename only changes case.  The
> error occurrs because ltdb_rename() calls ltdb_add_internal() and then
> ltdb_delete_internal() to accomplish the rename.  When the rename only
> changes case, the ltdb_add_internal() call fails because the DN already
> exists.
> 
> The attached patch compares the old and new DNs, and if they are the
> same it calls ltdb_modify_internal() with the flags set to
> LDB_FLAG_MOD_REPLACE.  If the DNs differ, the original
> ltdb_add_internal() / ltdb_delete_internal() code is used.

Andrew in which case do you need this?
Have you seen some operation failing because of case differences only in
the RDN ?
I ask because I am not sure we should succeed (or just perform a noop)
when the RDN attribute is case insensitive.
Do we fail if the attribute is case sensitive? (I expect the dn
comparison to fail).

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer
email: idra at samba.org
http://samba.org