Bug in talloc_asprintf_append()

Jeremy Allison jra at samba.org
Fri Sep 14 16:49:27 GMT 2007

On Fri, Sep 14, 2007 at 03:42:16PM +0200, Stefan (metze) Metzmacher wrote:

> I know, all I wanted to say was that the length calculation
> should be the same in talloc_append_string() and talloc_asprintf_append().

> I think we need talloc_*_append_end() functions which use
> the optimisation, as this is the reason the RPC-ECHO timeouts
> when the validate option is used.

I'm happy with that name.

> This test needed 21 seconds before and is now killed by the timeout
> code after 1200 seconds.

Volker, will adding a talloc_string_append_end() function satisfy ?
It's name is different enough that it makes people look at the
docs rather than making the assumtion of talloc_string_append().


More information about the samba-technical mailing list