[proof of concept] libwbclient.so

Gerald (Jerry) Carter jerry at samba.org
Fri Sep 7 16:29:08 GMT 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Danilo Almeida wrote:
> Jerry wrote:
> 
>> One alternative that Danilo (at work) suggested is just
> 
> Some additional suggestions...
> 
> 1) For the status codes, use WBC_STATUS_ as a prefix instead 
> of just WBC_.  This keeps the namespace cleaner.

How about WBC_ERR_ (STATUS is twice as long as ERR)? :-)

> 2) Why is enum wbcSidType using WBC_SID_NAME_... instead 
> of WBC_SID_TYPE_?

It's from the LSA IDL.

> 3) Why not have full consistency wrt to typedefs and have 
> all the types typedefed with _wbc -> wbc?  This also implies
> domain_sid -> wbcDomainSid and domain_info -> wbcDomainInfo.

Agreed.  Just hasn't been done yet.  I'll get that in the
next round.

> 4) We should probably have a proposed versioning solution 
> different that using library versions.  Consider these scenario
> where some important app uses libfoo and libbar.  In addition,
> there is a wbclient v1 where a wbcLogin call takes a list of
> SIDs and a v2 where a wbcLogin takes a list of names.  libfoo
> uses wbclient v1 and libbar uses wbclient v2...  Now we could
> get symbols conflicts in the app.  I would like a solution to
> be documented to version the API such that we can have an
> interim period where winbind ships with a v1 and v2 API and
> an app can link against libs that might be using different
> API versions.

Shipping an older version of the API/library against a
newer Winbind implementation is certainly doable.  But I don't have a
good solution to libraries using libraries.
And I don't want to make the API overly complicated to use.




cheers, jerry
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFG4XxTIR7qMdg1EfYRAqOaAKCOUFpBycFs81b8fHD93PovoQ5XqwCbBVty
yhkxFvQMqlpND+pjQ+2+a+c=
=JxBI
-----END PGP SIGNATURE-----


More information about the samba-technical mailing list