[proof of concept] libwbclient.so

simo idra at samba.org
Thu Sep 6 22:18:43 GMT 2007


On Thu, 2007-09-06 at 16:50 -0500, Gerald (Jerry) Carter wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Gerald (Jerry) Carter wrote:
> 
> > One thing that did come up is the handy use of talloc().
> > I thought about this and even built the libsambautil.so
> > which included talloc for use by libwbclient.  But in the
> > end, I felt like it was unfair to cross the API boundary
> > with TALLOC_CTX* and therefore require the calling
> > application to use talloc.  I love talloc, but at least for
> > right now, I think it is better to stick with malloc().
> > 
> > This does mean that I've got to find a better way to manage
> > memory in wbcLookupRids().  And we take a bit of a hit having
> > to copy memory in winbind_lookup_rids().  Suggestions welcome.
> 
> One alternative that Danilo (at work) suggested is just
> keeping the talloc use internal to the library and wrapping
> the talloc_destroy() in a wbcFree() call.  That helps with
> the library memory management but not the copying with smbd.

Uhm I guess I should read all mail in a thread before answering :-)
Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer
email: idra at samba.org
http://samba.org



More information about the samba-technical mailing list