Patch: Request correct access right for setprinterdata

Gerald (Jerry) Carter jerry at samba.org
Tue Sep 4 14:26:18 GMT 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Uri,

> Attached patch for samba_3_2 changes the requested access from 
> MAXIMUM_ALLOWED_ACCESS to PRINTER_ALL_ACCESS. Otherwise the client will get 
> an access denied when it tries to set a value.

This indicates a bug in the server code.  The server should
grant the client the max access rights available.  If the client
has PRINTER_ALL_ACCESS, the the two requested access masks
should result in the same access rights on the opened handle.

I'm assuming this is against running against a Samba server.
Do you have the level 10 debug logs available somewhere online?

> This sets the requested access to be the same as requested in 
> net_rpc_printers.c.

Also, please don't include reformatting and code changes in
the same patch.  Thanks.





cheers, jerry
=====================================================================
Samba                                    ------- http://www.samba.org
Centeris                         -----------  http://www.centeris.com
"What man is a man who does not make the world better?"      --Balian
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFG3WsKIR7qMdg1EfYRAlVGAKDBIsy+tq+wq0PvWGKVWLgc2ZUi7ACfVjIn
PVVXNwApUkhj5CQtlrDcD3k=
=vbc/
-----END PGP SIGNATURE-----


More information about the samba-technical mailing list