[proof of concept] libwbclient.so

[Gerald (Jerry) Carter]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Metze,

>> New files and patch posted to
>>   http://samba.org/~jerry/src/libwbclient/
> 
>> This includes the SID<->String conversion utilities.  Also need to
>> finish wbcErrorString() to the user-friendly error descriptions.
> 
> some notes about the naming:
> 
> - If the library is called wbclient then we should use
>   wbclient_ as prefix

We can, but that bets a little bit wordy IMO.  libsmbclient
use smbc_

> - I think it would be nicer to avoid typedef's
>   and use 'enum wbclient_status'

The reason I choose a typedef was to allow swapping out
a different data structure for a return code during development.
If everyone agrees that an enum is the correct decision,
then I have no problem removing the typedef.

> - and we should use 'dom_sid' as in all current idl files
>   instead of 'domain_sid'

Maybe.  But in reference to my previous mail, I really believe
that decoupling from Samba internals is a good thing here.
I can be convinced though since smbd is a primary consumer
of the API and the dom_sid is a pretty static data structure.





cheers, jerry
=====================================================================
Samba                                    ------- http://www.samba.org
Centeris                         -----------  http://www.centeris.com
"What man is a man who does not make the world better?"      --Balian
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFG21LgIR7qMdg1EfYRAgmoAJ0eLjIwi5c3z+hx8XMQFCsw2Hk0AgCeLpSx
6RoY1xpJKUWQStqojt8cGpA=
=llW0
-----END PGP SIGNATURE-----