[PATCH] NSS Wrapper 04

Andrew Bartlett abartlet at samba.org
Tue Oct 30 02:37:41 GMT 2007

On Fri, 2007-10-19 at 11:34 +0200, Stefan (metze) Metzmacher wrote:
> Hi,
> here's a patchset that implements NSS Wrapper
> simular to Socket Wrapper.
> This also removes the build-farm specific faked users hack.
> It works like this:
>   should hold the path of files formated like /etc/passwd
>   and /etc/group. The behavior is simluar to the nss_files
>   backend, but the initgroups() call always returns EPERM.
> - with the nss_wrapper.pl script it's possible to add or delete
>   entries (currently only users).
> This can be extended in future as needed, but it's much better
> then the build-farm specific hack, and it makes it possible to
> start winbindd in make test, as the objects are created persistent
> and not in memory of one specific process.
> Comments are welcome:-)

While the GIT format is great for showing how you constructed the patch,
it's also rather hard to read for 'what is the end result'.  That said
code looks pretty good, as I would expect, and it is nice to get rid of
the build farm hacks.

My one comment is about nwrap_getgrgid_r().  Is it really safe/correct
to have it calling nwrap_getgrgid() internally?  Shouldn't that be the
other way around?

Andrew Bartlett

Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Red Hat Inc.                  http://redhat.com

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20071030/c4fbe51e/attachment.bin

More information about the samba-technical mailing list