[PATCH] Improve Samba4's LDB consistancy

Stefan (metze) Metzmacher metze at samba.org
Mon Oct 29 11:12:16 GMT 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Andrew Bartlett schrieb:
> On Mon, 2007-10-29 at 10:22 +0100, Stefan (metze) Metzmacher wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> Stefan (metze) Metzmacher schrieb:
>>> Hi Andrew,
>>>
>>>> I've modified the objectclass module to improve consistency in Samba4.
>>>> The aim here is to ensure that if we have
>>>> CN=Users,DC=samba,DC=example,DC=com
>>>> that we cannot have a DN of the form
>>>> cn=admin ,cn=useRS,DC=samba,DC=example,DC=com
>>>> This module pulls apart the DN, fixes up the relative DN part, and
>>>> searches for the parent to copy the base from.
>>>> I've used the objectclass module, as I intend to also validate the
>>>> placement of child objects, by reading the allowedChildClasses virtual
>>>> attribute. 
>>>> In the future, I'll also force the attribute names to be consistant
>>>> (using the case from the schema). 
>> Please also take a look at
>>
>> dsdb/samdb/ldb_modules/repl_meta_data.c line 370...
> 
> The difference with my patch is that I'm trying to use the parent DN as
> the base, so that the rest of the DN (case of the container etc) is
> consistent.  So I can't just copy the DN and fix the case of the RDN
> attribute.
> 
> Is there a reason to go via the schema when upper-casing the attribute
> name? 

What I mean is that the rdn attribute (not inside the DN) and the "name"
attribute needs updating and for the rdn attribute the casing should be
taken from the schema (I assume we should do that for each attribute
before storing)

metze
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iD8DBQFHJcAQm70gjA5TCD8RAmjMAJ0fPEiFTp2JUJV/mI1gOwjt2uO81QCgmqo2
FqxSTElQo7PeSEg+Qw74br8=
=bm+d
-----END PGP SIGNATURE-----


More information about the samba-technical mailing list