SOCKET_WRAPPER_PCAP_FILE on debian x86_64

[Andrew Bartlett]

On Mon, 2007-10-22 at 08:18 +0200, Stefan (metze) Metzmacher wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Hi Andrew,
> 
> > I've been trying to get some SOCKET_WRAPPER_PCAP_FILE based traces off a
> > debian unstable x86_64 virtual machine, but it seems (from tracing in
> > GDB) that we are failing this
> > 	/*
> > 	 * TODO: don't use the structs use plain buffer offsets
> > 	 *       and PUSH_U8(), PUSH_U16() and PUSH_U32()
> > 	 * 
> > 	 * for now make sure we disable PCAP support
> > 	 * if the struct has alignment!
> > 	 */
> > 	if (sizeof(h) != SWRAP_FILE_HDR_SIZE) {
> > 		return NULL;
> > 	}
> > 
> > Is there something I should be doing to ensure we don't get this
> > aligned, or are you intending to fix it up to use push macros?  
> 
> I think using a byte-array and macros like CVAL(),SVAL(),IVAL() should
> be used, but I didn't used them because of the different licence of
> byteorder.h and socket_wrapper.c.

ok

> > I find the PCAP output to be most useful, so it was a disappointment for
> > it not to work (particularly without a warning or notice). 
> 
> yes, it's really usefull:-)
> 
> Have you notices that we have 'make test-swrap-pcap' and
> 'make test-swrap-keep-pcap' now?

I think we are getting too many different make targets...

Andrew Bartlett

-- 
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Red Hat Inc.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20071022/97ce6361/attachment.bin