Coding style updates

Jelmer Vernooij jelmer at samba.org
Fri Oct 19 10:23:06 GMT 2007


Am Freitag, den 19.10.2007, 10:39 +0200 schrieb Stefan (metze) Metzmacher:
> +
> +These should only be use together with return, goto, exit() or free():
> +
> +	if (x == 1) return 0;
> +
> +	if (some_long_function_name_check(x))
> +		goto failed;
> +
> +	if (ptr) free(ptr);
> +
I prefer an explicit "!= NULL" in the expression when checking a pointer
and always having the action on the next line.

Not a big deal though and the other changes are much of an improvement,
so +1.

Cheers,

Jelmer
-- 
Jelmer Vernooij <jelmer at samba.org> - http://samba.org/~jelmer/
Jabber: jelmer at jabber.fsfe.org


More information about the samba-technical mailing list