Missing stuff from trunk and SAMBA_3_2 (Re: Opie build farm failure.)

[Stefan (metze) Metzmacher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jeremy Allison schrieb:
> On Wed, Oct 17, 2007 at 04:25:33PM -0700, Jeremy Allison wrote:
>> Here's the relevent bit from the smbd -d10 log.
>>
>> _samr_set_userinfo: jra does not possess sufficient rights
>> Attempting administrator password change for user samba1$
>> decode_pw_buffer: incorrect password length (-126453866).
>> decode_pw_buffer: check that 'encrypt passwords = yes'
>>
>> (running the build tests as user jra).
>>
>> This looks like an access rights screw-up, not a
>> crypto bug to me. Still investigating, but I
>> thought you'd want to know :-).
> 
> Yep, just confirmed it. If I add the following patch
> to the build farm scripts it becomes clear.
> 
> How did this used to work ?

Hi Jeremy,

this was a crypto bug, as this patch was missing:

http://gitweb.samba.org/?p=samba.git;a=commitdiff;h=b4746009735bf66b2578b884973c505b0363a79d

And I assume there're much more important fixes missing in v3-2-test.

So everybody should carefully review, what gets dropped here:
git show -p --stat 5c6c8e1fe93
http://gitweb.samba.org/?p=samba.git;a=commitdiff;h=5c6c8e1fe93

But please let us discuss what we will merge/cherry-pick into v3-2-test
before you do the git push.

also the -x option to git cherry-pick it very usefull when the picked
commit is already in the origin/ repository.

metze
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iD8DBQFHFxgrm70gjA5TCD8RAgOkAJ4vfOq/gzkgmk2/ANxVdRxRP/JGcACgp+ij
0dYXHa0eNYkmOWotVwdPfWg=
=M4DW
-----END PGP SIGNATURE-----