[REVIEW] launchd support for smbd and winbindd

[James Peach]

On Oct 15, 2007, at 3:48 PM, Gerald (Jerry) Carter wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> James Peach wrote:
>> Hi all,
>>
>> The series of patches below are the changes for launchd support  
>> ported
>> from the SAMBA_3_2 svn branch to the v3-2-test git branch. I believe
>> that I have preserved Jeremy's IPv6 changes. Note that while the
>> cherry-picked changes in the early patches are marked GPL2, this is
>> corrected to GPL3 in subsequent patches.
>>
>> These changes are available in the "feature/launchd" branch of
>> git://git.samba.org/jpeach/samba.git. You should be able to apply  
>> them
>> to a local branch by sending this message into some form of git-am
>> invocation.
>>
>> If there are no dissenting voices, I'll merge this to v3-2-test  
>> before
>> the end of this week.
>
> James,
>
> I believe we got winbindd running under launchd without any
> code changes.  I've CC'd Danilo on this thread in case he wants
> to add specifics.  I guess what I'm trying to figure out
> is why your patch is necessary?  I remember talking about it
> in the past but don't remember the details.


In general, for an application to be a good launchd citizen it should
	1. launch on-demand, poking launchd to acquire any file descriptors
	2. pro-actively exit when it's idle
	3. not unlink named pipes that launchd is listening on

winbindd does none of these. You can certainly configure launchd to  
simply keep winbindd running, but in that case it would be a permanent  
system service. For most cases on OS X, it is preferable to have  
winbindd launched on demand.

--
James Peach | jpeach at samba.org