[Samba4] [FreeBSD] Conflicting definition of MACHINE macro

[Jelmer Vernooij]

Am Montag, den 08.10.2007, 04:44 +0200 schrieb Timur I. Bakeyev:
> Here is another problem. Compilation of the policy subsystem fails due
> to the conflict of the system-wide definition of the MACHINE macro and
> local MACHINE macro in the lib/policy/lex.l. In the recent SVN versions
> this was fixed by renaming macro into CLASS_MACHINE, but usage of the
> simple name macros like CLASS, DEFAULT, etc. is asking for troubles, as
> these names are too common and may be used somewhere else. The best
> practice here is to give more application specific names to the macros,
> let's say prepend them with the POL_ prefix in this case.
I'm not convinced this is necessary. These are enum values (basically
defines), so they don't clutter the global symbol namespace. All they
can conflict with are defines in the system headers and that doesn't
appear to be a problem at the moment.

Cheers,

Jelmer
-- 
Jelmer Vernooij <jelmer at samba.org> - http://samba.org/~jelmer/
Jabber: jelmer at jabber.fsfe.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 307 bytes
Desc: Dies ist ein digital signierter Nachrichtenteil
Url : http://lists.samba.org/archive/samba-technical/attachments/20071008/4e83f25e/attachment.bin