svn commit: samba r25495 - in branches: SAMBA_3_2/source/lib/replace/system SAMBA_3_2_0/source/lib/replace/system

Jeremy Allison jra at samba.org
Thu Oct 4 01:03:39 GMT 2007


On Wed, Oct 03, 2007 at 08:54:31PM -0400, simo wrote:
> On Thu, 2007-10-04 at 01:21 +0200, Henrik Nordstrom wrote:
> > On ons, 2007-10-03 at 15:35 -0700, Jeremy Allison wrote:
> > 
> > > I don't think we need to go that far - let's just watch the
> > > build farm and switch to a test for sockaddr_in6 if we need to.
> > 
> > Will the build farm notice? sockaddr_storage is only used for
> > allocations/storage, right? All uses is casted to the protocol specific
> > sockaddr_xx which silences any compiler warnings... so you'll end up
> > with some interesting memory corruption if ipv6 is enabled without
> > sockaddr_storage.
> > 
> 
> This was my fear as well.

Just wait your hurry. A simple configure test easy enough to
add to shut up all this moaning :-).


More information about the samba-technical mailing list