[PATCH] Add a warning for a potential bug I've run into

Volker Lendecke vl at sernet.de
Wed Nov 28 12:43:31 GMT 2007


---
 source/lib/tdb/common/traverse.c |    3 +++
 source/lib/tdb/docs/README       |    3 +++
 2 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/source/lib/tdb/common/traverse.c b/source/lib/tdb/common/traverse.c
index 2b9a4a2..0e92a71 100644
--- a/source/lib/tdb/common/traverse.c
+++ b/source/lib/tdb/common/traverse.c
@@ -230,6 +230,9 @@ int tdb_traverse_read(struct tdb_context *tdb,
 /*
   a write style traverse - needs to get the transaction lock to
   prevent deadlocks
+
+  WARNING: The data buffer given to the callback fn does NOT meet the
+  alignment restrictions malloc gives you.
 */
 int tdb_traverse(struct tdb_context *tdb, 
 		 tdb_traverse_func fn, void *private_data)
diff --git a/source/lib/tdb/docs/README b/source/lib/tdb/docs/README
index b31ce36..63fcf5e 100644
--- a/source/lib/tdb/docs/README
+++ b/source/lib/tdb/docs/README
@@ -130,6 +130,9 @@ int tdb_traverse(TDB_CONTEXT *tdb, int (*fn)(TDB_CONTEXT *tdb,
    a non-zero return value from fn() indicates that the traversal
    should stop. Traversal callbacks may not start transactions.
 
+   WARNING: The data buffer given to the callback fn does NOT meet the
+   alignment restrictions malloc gives you.
+
 ----------------------------------------------------------------------
 int tdb_traverse_read(TDB_CONTEXT *tdb, int (*fn)(TDB_CONTEXT *tdb,
                      TDB_DATA key, TDB_DATA dbuf, void *state), void *state);
-- 
1.5.3.4



More information about the samba-technical mailing list