[PATCH] Add stackframes to public libsmbclient functions

Jeremy Allison jra at samba.org
Wed Nov 28 06:55:44 GMT 2007

On Wed, Nov 28, 2007 at 07:50:27AM +0100, Volker Lendecke wrote:
> That's indeed very clever, thanks. If I had seen this
> proposal when I first added talloc_stackframe() I would
> probably have removed the stackframe thing immediately.

I'm very glad you didn't :-).

> On the other hand, talloc_tos() at least to me has proved to
> be very handy and in particular very robust. We've had quite
> a few memleaks due to temporary talloc contexts not being
> freed in obscure error returns. This does not mean that I
> intend to be sloppy, but it's a cozy feeling that things
> can't go really bad.

Indeed - it is a very handy way to convert older code
to talloc contexts - I'm finding it essential to keep
the diff size down whilst removing pstrings.

> I think Jeremy and Jerry should also comment here I think :-)

Just did :-).


More information about the samba-technical mailing list